Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(toolchain): use flag_values in test platform defs #2106

Merged
merged 3 commits into from
Aug 2, 2024
Merged

test(toolchain): use flag_values in test platform defs #2106

merged 3 commits into from
Aug 2, 2024

Conversation

aignas
Copy link
Collaborator

@aignas aignas commented Aug 1, 2024 •
edited
Loading

This PR uses the flag_values from the platform definitions
for the toolchains so that in the future we can distinguish
between musl and glibc toolchains in our tests.

For now the change is no-op.

As part of this change we are also registering the coverage
tools so that we can run bazel coverage with no errors.

See comment on #2095.

@aignas aignas requested a review from rickeylev as a code owner August 1, 2024 09:03
@aignas aignas mentioned this pull request Aug 1, 2024
Merged
@aignas aignas changed the title test(toolchain): use flag_values in test platform defs test(toolchain): use flag_values in test platform defs and register coverage Aug 1, 2024
@aignas aignas requested a review from groodt August 1, 2024 18:57
rickeylev
rickeylev approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@rickeylev rickeylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the description to better describe the change? A PR/issue number is nice, but I prefer commits to be more self-descriptive.

python/private/python.bzl Outdated Show resolved Hide resolved
@aignas aignas changed the title test(toolchain): use flag_values in test platform defs and register coverage test(toolchain): use flag_values in test platform defs Aug 2, 2024
@aignas aignas enabled auto-merge August 2, 2024 08:28
@aignas aignas added this pull request to the merge queue Aug 2, 2024
Merged via the queue into bazelbuild:main with commit fa13b01 Aug 2, 2024
4 checks passed
@aignas aignas mentioned this pull request Aug 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickeylev rickeylev rickeylev approved these changes

@groodt groodt Awaiting requested review from groodt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aignas @rickeylev