fix: missing RunEnvironmentInfo #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
rickeylev
approved these changes
Nov 29, 2022
Signed-off-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
ianpegg-bc
pushed a commit
to ianpegg-bc/rules_python
that referenced
this pull request
May 12, 2023
* fix: missing RunEnvironmentInfo Signed-off-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com> * fix: add reference to github issue Signed-off-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com> Signed-off-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After we introduced multi-toolchain support, the release failed because
RunEnvironmentInfois only available on Bazel 5.3.0+ and there was a bug in how we checked for the existence of this provider. Apparently, there's no way to check for this provider, so I reverted to the deprecatedtesting.TestEnvironment. Once we are okay with not supporting Bazel < 5.3.0, we can move toRunEnvironmentInfo.