Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing RunEnvironmentInfo #904

Merged
merged 2 commits into from
Nov 29, 2022
+3 −2
Merged

fix: missing RunEnvironmentInfo #904

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
775480c
fix: missing RunEnvironmentInfo
f0rmiga Nov 29, 2022
2204f1c
fix: add reference to github issue
f0rmiga Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions python/config_settings/transition.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,11 @@ def _transition_py_impl(ctx):
dependency_attributes = ["target"],
),
target[OutputGroupInfo],
# testing.TestEnvironment is deprecated in favour of RunEnvironmentInfo but
# TODO(f0rmiga): testing.TestEnvironment is deprecated in favour of RunEnvironmentInfo but
f0rmiga marked this conversation as resolved.
Show resolved Hide resolved
# RunEnvironmentInfo is not exposed in Bazel < 5.3.
# https://github.com/bazelbuild/rules_python/issues/901
# https://github.com/bazelbuild/bazel/commit/dbdfa07e92f99497be9c14265611ad2920161483
(RunEnvironmentInfo if hasattr(native, "RunEnvironmentInfo") else testing.TestEnvironment)(environment = env),
testing.TestEnvironment(environment = env),
]
return providers

Expand Down