-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gazelle)!: Move the plugin to a separate workspace #972
Conversation
5ae27f4
to
abde25c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look great. I have some nitpicks that I noticed, but I like it!! Working on the build_file_generation example I was wondering if bzmod and gazelle where working.
7b0ec08
to
2ad688f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
FYI @f0rmiga is on paternity leave, back next week I believe |
@alexeagle who else can review it? |
I think we should probably just wait for @f0rmiga to be back. This will need someone to invest a few hours. As one way to make this easier to land, @aignas is it possible to split out a separate PR that does the directory rename so this doesn't show as a 433 files changed? Or leave the directory rename for a subsequent refactoring? I can't even get started on reviewing it at this size without setting aside a chunk of my day. (Also, thank you for taking this on!!) |
Hey @alexeagle, I also think that waiting for @f0rmiga is probably for the best. I can split it to several commits at the very least. I think the rename is necessary to make everything work as we are moving the What I can do to make it easier to review is to split it into multiple PRs introducing a breaking change:
How does it sound to you? And sorry for making the initial PR too long, I was mainly looking at the changed lines counter. |
Yeah I think the folder rename first will make it more manageable. Thanks! |
This is in order to make bazelbuild#972 easier to review. This PR is only moving files and addressing a few small review comments made in the initial review of bazelbuild#972. Work towards bazelbuild#965.
2ad688f
to
69aa5ec
Compare
This is in order to make bazelbuild#972 easier to review. This PR is only moving files and addressing a few small review comments made in the initial review of bazelbuild#972. Work towards bazelbuild#965.
69aa5ec
to
3e43501
Compare
This is in order to make bazelbuild#972 easier to review. This PR is only moving files and addressing a few small review comments made in the initial review of bazelbuild#972. Work towards bazelbuild#965.
3e43501
to
b4050a5
Compare
This is in order to make bazelbuild#972 easier to review. This PR is only moving files and addressing a few small review comments made in the initial review of bazelbuild#972. Work towards bazelbuild#965.
d1de560
to
d9bd232
Compare
Summary: * Move go.mod to gazelle. * Move gazelle definition. * Fix file distribution for the gazelle module. * Update the example test. * Include rules_python_gazelle_plugin during integration tests * Update ignored packages * Update CI configuration
d9bd232
to
dc0db9d
Compare
Thanks for addressing this, @aignas! |
feat!(gazelle): Move the plugin to a separate workspace Summary: * Move go.mod to gazelle. * Move gazelle definition. * Fix file distribution for the gazelle module. * Update the example test. * Include rules_python_gazelle_plugin during integration tests * Update ignored packages * Update CI configuration
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Previously the gazelle plugin was part of the same
WORKSPACE
. This means that we cannot have a separatebzlmod
module and make therules_python
repo work with both,bzlmod
and legacy dependency management systems.Issue Number: #965
What is the new behavior?
The
gazelle
plugin is now isolated with its ownWORKSPACE
file. Whilst making this I have also moved the plugin source code to a separate directory.Summary:
gazelle
definition.Move the gazelle plugin to a separate folder, just likeThis is now refactor(gazelle): Move plugin to a separate directory. #983.bazel-skylib
does, which helps with naming of the externally visible targets.distribution
for the gazelle module.Does this PR introduce a breaking change?
Steps that need to be taken:
WORKSPACE
and change the import path for the plugin dependency setup.@rules_python_gazelle_plugin//python:gazelle_binary
.@rules_python_gazelle_plugin//python
.gazelle_python.yaml
integrity gets changed for all users.