refactor(gazelle): Move plugin to a separate directory. #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aignas
force-pushed
the
gazelle-move-plugin-to-dir
branch
2 times, most recently
from
6257e87
to
b7743a9
Compare
12 tasks
|
@f0rmiga, could you please take a look when you have time? |
|
Well, now I'm a bit confused because we just added "optional" dependencies https://github.com/bazelbuild/rules_python/blob/main/MODULE.bazel#L9-L11 |
|
I somewhat still think that having this refactoring in won't hurt, given that once it is done we can either way - a single |
f0rmiga
approved these changes
Jan 23, 2023
This is in order to make bazelbuild#972 easier to review. This PR is only moving files and addressing a few small review comments made in the initial review of bazelbuild#972. Work towards bazelbuild#965.
aignas
force-pushed
the
gazelle-move-plugin-to-dir
branch
from
b7743a9
to
44398ef
Compare
ianpegg-bc
pushed a commit
to ianpegg-bc/rules_python
that referenced
this pull request
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
@alexeagle requested to split #972 into multiple PRs for easier review, so this is the first part.
Issue Number: #965
What is the new behavior?
This is in order to make #972 easier to review. This PR is only moving files and addressing a few small review comments made in the initial review of #972. I have also made
aliastargets to make this a non-breaking change from the user point of view in case a release is made before the breaking change of introducing the newWORKSPACEis merged.Work towards #965.
Does this PR introduce a breaking change?
Other information