Skip to content

Commit

Permalink
Revert "Add test/incompatible_changes package and exempt it from defa…
Browse files Browse the repository at this point in the history
…ult CI tests" (#1060)

This reverts #1050

Since this commit I learned that one can test incompatible changes through transitions as in #1057. Thus, we don't need a separate directory for easier testing.
  • Loading branch information
scentini committed Dec 9, 2021
1 parent 23a4631 commit e50b151
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions .bazelci/presubmit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,7 @@ aspects_flags: &aspects_flags
- "--config=rustfmt"
- "--config=clippy"
default_linux_targets: &default_linux_targets
- "--" # Allows negative patterns; hack for https://github.com/bazelbuild/continuous-integration/pull/245
- "//..."
- "-//test/incompatible_changes/..."
# TODO: Switch manual tag to platform constraint after bazel 4.0.
- "//test/versioned_dylib:versioned_dylib_test"
default_macos_targets: &default_macos_targets
Expand All @@ -17,7 +15,6 @@ default_windows_targets: &default_windows_targets
- "-//test/proto/..."
- "-//tools/rust_analyzer/..."
- "-//test/rustfmt/..."
- "-//test/incompatible_changes/..."
tasks:
ubuntu2004:
build_targets: *default_linux_targets
Expand All @@ -33,7 +30,6 @@ tasks:
- "//..."
- "//test/..."
- "-//test/conflicting_deps:conflicting_deps_test"
- "-//test/incompatible_changes/..."
macos:
build_targets: *default_macos_targets
test_targets: *default_macos_targets
Expand Down Expand Up @@ -62,7 +58,6 @@ tasks:
- "--" # Allows negative patterns; hack for https://github.com/bazelbuild/continuous-integration/pull/245
- "..."
- "//test/..."
- "-//test/incompatible_changes/..."
- "-//test/conflicting_deps:conflicting_deps_test"
build_flags: *aspects_flags
rbe_ubuntu1604_rolling_with_aspects:
Expand All @@ -76,7 +71,6 @@ tasks:
- "--" # Allows negative patterns; hack for https://github.com/bazelbuild/continuous-integration/pull/245
- "..."
- "//test/..."
- "-//test/incompatible_changes/..."
- "-//test/conflicting_deps:conflicting_deps_test"
build_flags: *aspects_flags
soft_fail: yes
Expand Down
Empty file.

0 comments on commit e50b151

Please sign in to comment.