Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add incompatible_changes package and exempt it from default CI tests #1050

Merged
merged 2 commits into from
Dec 1, 2021
Merged

Add incompatible_changes package and exempt it from default CI tests #1050

merged 2 commits into from
Dec 1, 2021

Conversation

scentini
Copy link
Collaborator

@scentini scentini commented Dec 1, 2021

So it's easier to add a task that tests an incompatible flag

@google-cla google-cla bot added the cla: yes label Dec 1, 2021
@scentini scentini requested a review from hlopko December 1, 2021 12:15
@scentini scentini marked this pull request as ready for review December 1, 2021 12:15
@hlopko hlopko merged commit 9d70a5a into bazelbuild:main Dec 1, 2021
@scentini scentini mentioned this pull request Dec 9, 2021
Merged
scentini added a commit that referenced this pull request Dec 9, 2021
@scentini
Revert "Add test/incompatible_changes package and exempt it from defa…
e50b151 
…ult CI tests" (#1060)

This reverts #1050

Since this commit I learned that one can test incompatible changes through transitions as in #1057. Thus, we don't need a separate directory for easier testing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlopko hlopko hlopko approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@scentini @hlopko