Skip to content

Commit

Permalink
Remove incorrect paren in bingen repositories (#488)
Browse files Browse the repository at this point in the history
I was trying to setup some testing on various versions of bazel when I
kept running into this issue that causes bazel query to error out.
However, the error handling is specifc to earlier 3.X series versions of
bazel.  Prior to this patch, this causes and error:
```
bazel-3.4.0 query -- //... - @examples//...
```
however, this does not error out:
```
bazel-3.5.0 query -- //... - @examples//...
```
which is why rules_rust tests are probably still passing.

This removes the unintentional paren, which removes the issue in all 3.X
cases that I tested.
  • Loading branch information
David Freese committed Nov 11, 2020
1 parent 8d2b4ee commit fb6460c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion bindgen/repositories.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ workspace(name = "{}")
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
http_archive()
http_archive(
name = "rules_cc",
url = "https://github.com/bazelbuild/rules_cc/archive/624b5d59dfb45672d4239422fa1e3de1822ee110.zip",
sha256 = "8c7e8bf24a2bf515713445199a677ee2336e1c487fa1da41037c6026de04bbc3",
Expand Down

0 comments on commit fb6460c

Please sign in to comment.