Remove incorrect paren in bingen repositories #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was trying to setup some testing on various versions of bazel when I kept running into this issue that causes bazel query to error out. However, the error handling is specifc to earlier 3.X series versions of bazel. Prior to this patch, this causes and error: ``` bazel-3.4.0 query -- //... - @examples//... ``` however, this does not error out: ``` bazel-3.5.0 query -- //... - @examples//... ``` which is why rules_rust tests are probably still passing. This removes the unintentional paren, which removes the issue in all 3.X cases that I tested.
UebelAndre
approved these changes
Nov 11, 2020
UebelAndre
approved these changes
Nov 11, 2020
illicitonion
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to setup some testing on various versions of bazel when I
kept running into this issue that causes bazel query to error out.
However, the error handling is specifc to earlier 3.X series versions of
bazel. Prior to this patch, this causes and error:
however, this does not error out:
which is why rules_rust tests are probably still passing.
This removes the unintentional paren, which removes the issue in all 3.X
cases that I tested.