Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No actual toolchain_type for @io_bazel_rules_rust//rust:toolchain #128

Closed
katre opened this issue Oct 5, 2018 · 4 comments
Closed

No actual toolchain_type for @io_bazel_rules_rust//rust:toolchain #128

katre opened this issue Oct 5, 2018 · 4 comments
Assignees
Labels

Comments

@katre
Copy link
Member

katre commented Oct 5, 2018

With the fixes for bazelbuild/bazel#6015, there will be an actual dependency from toolchains back to the respective toolchain_type target. rules_rust currently does not actually define the toolchain_type, and so builds fail (see https://buildkite.com/bazel/bazel-with-downstream-projects-bazel/builds/480#f43a9298-b4e0-46da-980b-e6bcacdd5e5c).

Error:

ERROR: /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/7a687a53d9d341692c7f46223f63d5ca/external/rust_linux_x86_64_toolchains/BUILD:2:1: no such target '@io_bazel_rules_rust//rust:toolchain': target 'toolchain' not declared in package 'rust' (did you mean 'toolchain.bzl'?) defined by /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/7a687a53d9d341692c7f46223f63d5ca/external/io_bazel_rules_rust/rust/BUILD and referenced by '@rust_linux_x86_64_toolchains//:toolchain_for_x86_64-unknown-linux-gnu'
@katre
Copy link
Member Author

katre commented Oct 5, 2018

The fix is to define the toolchain_type target, which I will send a PR for shortly.

How difficult will it be to get this into a released rules_rust before Bazel 0.20.0 is cut (early November)?

@acmcarther
Copy link
Collaborator

Reopening: Release needs to be cut per #128 (comment)

@acmcarther acmcarther reopened this Oct 6, 2018
@acmcarther acmcarther assigned acmcarther and unassigned katre Oct 6, 2018
@acmcarther
Copy link
Collaborator

We haven't been diligently making releases of the rule set so theres a good sized backlog of changes. This weekend I'll collect the list of changes in a change log and release 0.0.7

@acmcarther
Copy link
Collaborator

Released 0.0.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants