Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rules_* jobs are failing with Bazel at HEAD #6311

Closed
meteorcloudy opened this issue Oct 5, 2018 · 4 comments
Closed

Rules_* jobs are failing with Bazel at HEAD #6311

meteorcloudy opened this issue Oct 5, 2018 · 4 comments
Assignees
@katre
Labels
breakage P1 I'll work on this now. (Assignee required) team-Configurability platforms, toolchains, cquery, select(), config transitions

Comments

@meteorcloudy
Copy link
Member

meteorcloudy commented Oct 5, 2018 •
edited
Loading

https://buildkite.com/bazel/bazel-with-downstream-projects-bazel/builds/480

ERROR: /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/b56e71a8651156a61b0ca6a115747ad7/external/go_sdk/BUILD.bazel:52:1: no such target '@io_bazel_rules_go//go:toolchain': target 'toolchain' not declared in package 'go'; however, a source directory of this name exists.  (Perhaps add 'exports_files(["toolchain"])' to go/BUILD, or define a filegroup?) defined by /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/b56e71a8651156a61b0ca6a115747ad7/external/io_bazel_rules_go/go/BUILD.bazel and referenced by '@go_sdk//:go_plan9_386'

Bisecting gives 2348893 as the culprit

@katre, can you confirm this? Also, maybe we are lacking some test coverage here.
@meteorcloudy meteorcloudy added P1 I'll work on this now. (Assignee required) breakage labels Oct 5, 2018
@lberki lberki mentioned this issue Oct 5, 2018
Closed
@katre katre added the team-Configurability platforms, toolchains, cquery, select(), config transitions label Oct 5, 2018
@katre
Copy link
Member

katre commented Oct 5, 2018

Yes, this is caused by 2348893. Please roll it back while I investigate.

@katre
Copy link
Member

katre commented Oct 5, 2018

Filed issues with rules_go (bazelbuild/rules_go#1752) and rules_rust (bazelbuild/rules_rust#128) to resolve this.

@katre
Copy link
Member

katre commented Oct 5, 2018

Downstream projects from rules_go that will need to be updated once rules_go releases the fix:

  • bazel-toolchains
  • buildtools
  • Gerrit
  • rules_docker
  • rules_nodejs
  • rules_sass
  • rules_typescript

bazel-io pushed a commit that referenced this issue Oct 5, 2018
@meteorcloudy
Automated rollback of commit 2348893.
4b8bf41 
*** Reason for rollback ***

This change is causing many rules_* jobs to fail at HEAD:

https://buildkite.com/bazel/bazel-with-downstream-projects-bazel/builds/480

Filed issue: #6311

*** Original change description ***

Add new ToolchainTypeInfo provider to track toolchain type information.

Will eventually be part of checking the toolchain provider types, as
part of #6015.

Closes #6235.

PiperOrigin-RevId: 215911302
@meteorcloudy
Copy link
Member Author

meteorcloudy commented Oct 5, 2018 •
edited
Loading

Closing since the breakage has gong away

https://buildkite.com/bazel/bazel-with-downstream-projects-bazel/builds/483

katre added a commit that referenced this issue Oct 19, 2018
@katre
Automated rollback of commit 4b8bf41.
4a73370 
*** Reason for rollback ***

rules_go has been updated

*** Original change description ***

Automated rollback of commit 2348893.

*** Reason for rollback ***

This change is causing many rules_* jobs to fail at HEAD:

https://buildkite.com/bazel/bazel-with-downstream-projects-bazel/builds/480

Filed issue: #6311

*** Original change description ***

Add new ToolchainTypeInfo provider to track toolchain type information.

Will eventually be part of checking the toolchain provider...

***

PiperOrigin-RevId: 217906109
Change-Id: I59be5f68d8bcc2c86190f8bf2e03843ef4620ee8
katre added a commit that referenced this issue Nov 1, 2018
@katre
Add new ToolchainTypeInfo provider to track toolchain type information.
b547998 
Will eventually be part of checking the toolchain provider.

The original change (4b8bf41) was rolled back due to many downstream Bazel
breakages (tracked as #6311). Downstream is now working (DO NOT SUBMIT).

PiperOrigin-RevId: 219660915
Change-Id: I8cacb8e383cba2d01e11bc7f7d800237c0321e97
katre added a commit that referenced this issue Nov 5, 2018
@katre
Add new ToolchainTypeInfo provider to track toolchain type information.
dac4cdb 
Will eventually be part of checking the toolchain provider.

The original change (4b8bf41) was rolled back due to many downstream Bazel
breakages (tracked as #6311). Downstream is now working (DO NOT SUBMIT).

PiperOrigin-RevId: 219660915
Change-Id: I8cacb8e383cba2d01e11bc7f7d800237c0321e97
katre added a commit to katre/bazel that referenced this issue Nov 6, 2018
@katre
Add new ToolchainTypeInfo provider to track toolchain type information.
402fd8b 
Will eventually be part of checking the toolchain provider.

The original change (bazelbuild@2348893) was rolled back due to many downstream Bazel
breakages (tracked as bazelbuild#6311). Downstream is now working (https://buildkite.com/bazel/bazel-with-downstream-projects-bazel/builds/561).

PiperOrigin-RevId: 220308101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katre katre

Labels
breakage P1 I'll work on this now. (Assignee required) team-Configurability platforms, toolchains, cquery, select(), config transitions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@katre @meteorcloudy