New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable //tools/runfiles on the Windows CI #616

Closed

hlopko opened this issue Feb 26, 2021 · 0 comments · Fixed by #760

Labels

good first issue help wanted maintenance windows

Member

hlopko commented Feb 26, 2021

Since #612 we test more stuff on Windows, we don't test everything though. //tools/runfiles is currently disabled in .bazelci/presubmit.yml.

Feel free to comment on this issue if you want to know more or you want to give it a shot. We are happy to talk or help :)

How to fix when you don't have a Windows machine:

delete the line with - "-//tools/runfiles/..."
upload a draft PR
see the CI failure
try to fix it

How to fix when you do have a Windows machine:

Try to repro the failure localy
Fix it
upload the PR :)

The text was updated successfully, but these errors were encountered:

hlopko added help wanted good first issue maintenance windows labels

hlopko mentioned this issue

Add support for manifest based runfiles. #760

Merged

hlopko closed this as completed in #760

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment