Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase CI coverage #612

Merged
merged 9 commits into from
Feb 26, 2021
Merged

Increase CI coverage #612

merged 9 commits into from
Feb 26, 2021

Conversation

hlopko
Copy link
Member

@hlopko hlopko commented Feb 25, 2021 •
edited
Loading

I realized we don't run tests on Windows. This PR fixes that. While there I also enabled tests on RBE.

@google-cla google-cla bot added the cla: yes label Feb 25, 2021
@hlopko hlopko marked this pull request as ready for review February 25, 2021 22:06
@hlopko
Copy link
Member Author

hlopko commented Feb 25, 2021

CC @UebelAndre

@hlopko hlopko changed the title Add CI coverage Increase CI coverage Feb 25, 2021
illicitonion
illicitonion approved these changes Feb 25, 2021
View reviewed changes
.bazelci/presubmit.yml Show resolved Hide resolved
UebelAndre
UebelAndre requested changes Feb 25, 2021
View reviewed changes
Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I'm curious how you actually ensure you're trying to enable more. If there's an automated way to remind you you're not testing everything or try to enable tests and see if something passes based on some change.

test/BUILD Outdated Show resolved Hide resolved
@hlopko
Copy link
Member Author

hlopko commented Feb 26, 2021

Sounds good. I'm curious how you actually ensure you're trying to enable more. If there's an automated way to remind you you're not testing everything or try to enable tests and see if something passes based on some change.

I don't think they will be fixed accidentally, so a system automatically checking if they pass won't be very useful. I'll create issues for them and we should try to fix them soon.

This was referenced Feb 26, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Open
@hlopko hlopko merged commit 9b135bf into bazelbuild:main Feb 26, 2021
@hlopko hlopko deleted the enable_windows branch April 1, 2021 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UebelAndre UebelAndre UebelAndre requested changes

@illicitonion illicitonion illicitonion approved these changes

@mfarrugi mfarrugi Awaiting requested review from mfarrugi

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hlopko @illicitonion @UebelAndre