Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for manifest based runfiles. #760

Merged
merged 4 commits into from
Jun 2, 2021
Merged

Add support for manifest based runfiles. #760

merged 4 commits into from
Jun 2, 2021

Conversation

hlopko
Copy link
Member

@hlopko hlopko commented Jun 1, 2021 •
edited
Loading

These are typically used on Windows when using symlinks which are needed
for directory based runfiles is not possible.

Fixes #616.

@google-cla google-cla bot added the cla: yes label Jun 1, 2021
@hlopko hlopko mentioned this pull request Jun 1, 2021
Merged
UebelAndre
UebelAndre approved these changes Jun 1, 2021
View reviewed changes
Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment but otherwise looks good to me!

tools/runfiles/runfiles.rs Show resolved Hide resolved
@hlopko
Add support for manifest based runfiles.
ac9d2d8 
These are typically used on Windows when using symlinks which are needed
for directory based runfiles is not possible.
@hlopko
Enable runfiles on the CI
5ee74a5
@hlopko
Fix doc test
d5f29e0
@hlopko hlopko merged commit b8219ac into bazelbuild:main Jun 2, 2021
@hlopko hlopko deleted the runfiles branch June 2, 2021 07:09
hlopko added a commit that referenced this pull request Jun 9, 2021
@hlopko
Make rust analyzer aspect follow rust_test.crate attribute (#751)
087bcab 
Before, generated rust-project.json did not contain dependencies from the `rust_library` when `rust_test` used `.crate` attribute and the test was the only root in the `targets` attribute of `rust_analyzer` rule.

This PR depends on #754 and #760.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illicitonion illicitonion illicitonion approved these changes

@UebelAndre UebelAndre UebelAndre approved these changes

@dfreese dfreese Awaiting requested review from dfreese

@mfarrugi mfarrugi Awaiting requested review from mfarrugi

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable //tools/runfiles on the Windows CI
3 participants
@hlopko @illicitonion @UebelAndre