Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable //bindgen on the Windows CI #617

Closed
hlopko opened this issue Feb 26, 2021 · 1 comment
Closed

Enable //bindgen on the Windows CI #617

hlopko opened this issue Feb 26, 2021 · 1 comment

Comments

@hlopko
Copy link
Member

hlopko commented Feb 26, 2021

Since #612 we test more stuff on Windows, we don't test everything though. //bindgen is currently disabled in .bazelci/presubmit.yml.

Feel free to comment on this issue if you want to know more or you want to give it a shot. We are happy to talk or help :)

How to fix when you don't have a Windows machine:

  1. delete the line with - "-//bindgen/..."
  2. upload a draft PR
  3. see the CI failure
  4. try to fix it

How to fix when you do have a Windows machine:

  1. Try to repro the failure localy
  2. Fix it
  3. upload the PR :)
@hlopko hlopko changed the title Enable //bindgen on Windows CI Enable //bindgen on the Windows CI Feb 26, 2021
@UebelAndre
Copy link
Collaborator

This was enabled by #1998

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants