use absolute value of hash function to determine crate name #1064
+36
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No functional changes intended. Previously the library names of rlibs sometimes had two dashes, like libslib--389267823.rlib. This happens because the hash() function may return a negative value, so the second dash is the minus sign. However such names are a bit confusing since they look like there's a missing component between the two dashes that didn't get properly propagated, which is not true. For the unit test, since the hash() function is the standard Java String hashCode function, I chose "slib" since that produces a negative hash code.
UebelAndre
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes intended.
Previously the library names of rlibs sometimes had two dashes, like
libslib--389267823.rlib. This happens because the hash() function may
return a negative value, so the second dash is the minus sign. However
such names are a bit confusing since they look like there's a missing
component between the two dashes that didn't get properly propagated,
which is not true.
For the unit test, since the hash() function is the standard Java String hashCode
function, I chose "slib" since that produces a negative hash code.