Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use absolute value of hash function to determine crate name #1064

Merged
merged 3 commits into from
Dec 14, 2021

Commits on Dec 13, 2021

  1. use absolute value of hash function to determine crate name

    No functional changes intended.
    Previously the library names of rlibs sometimes had two dashes, like
    libslib--389267823.rlib.  This happens because the hash() function may
    return a negative value, so the second dash is the minus sign. However
    such names are a bit confusing since they look like there's a missing
    component between the two dashes that didn't get properly propagated,
    which is not true.
    For the unit test, since the hash() function is the standard Java String hashCode
    function, I chose "slib"  since that produces a negative hash code.
    krasimirgg committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    222ded5 View commit details
    Browse the repository at this point in the history
  2. update hello test

    krasimirgg committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    60a125d View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2021

  1. move comment to docstring

    krasimirgg committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    e6a6e49 View commit details
    Browse the repository at this point in the history