Provide pdb file for cydlib/bin on Windows in a pdb_file output group
#1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddeville
force-pushed
the
windows-pdb
branch
from
8b0e966
to
e30d133
Compare
|
Looks like the test launcher adds its own |
ddeville
force-pushed
the
windows-pdb
branch
from
e30d133
to
5cc6a21
Compare
|
The launcher is actually something I think we need to remove. I can ad an incompatibility flag for it |
ddeville
force-pushed
the
windows-pdb
branch
2 times, most recently
from
c222696
to
32518eb
Compare
I've chose the `pdb_file` name for the output group since it matches what `cc_binary` uses (https://cs.opensource.google/bazel/bazel/+/master:src/main/java/com/google/devtools/build/lib/rules/cpp/CcBinary.java;l=707) There is one edge case that is not covered here: if the user passes `/DEBUG:NONE` in the `rustc_flags` no pdb will be generated and I imagine the build will fail since it's now missing an output. I guess we could check the `rustc_flags` for it but I don't know if it's the right place to do so?
ddeville
force-pushed
the
windows-pdb
branch
from
32518eb
to
0bc4fdf
Compare
Sorry this took so long. I've opened #1070 |
UebelAndre
approved these changes
Dec 16, 2021
UebelAndre
approved these changes
Dec 16, 2021
ddeville
force-pushed
the
windows-pdb
branch
2 times, most recently
from
57f0e43
to
f2a641d
Compare
ddeville
force-pushed
the
windows-pdb
branch
from
f2a641d
to
2c92366
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've chose the
pdb_filename for the output group since it matches whatcc_binaryuses(https://cs.opensource.google/bazel/bazel/+/master:src/main/java/com/google/devtools/build/lib/rules/cpp/CcBinary.java;l=707)
There is one edge case that is not covered here: if the user passes
/DEBUG:NONEin therustc_flagsno pdb will be generated and I imagine the build will fail since it's now missing an output. I guess we could check therustc_flagsfor it but I don't know if it's the right place to do so?