Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide pdb file for cydlib/bin on Windows in a pdb_file output group #1065

Merged
merged 2 commits into from
Dec 16, 2021
Merged

Provide pdb file for cydlib/bin on Windows in a pdb_file output group #1065

merged 2 commits into from
Dec 16, 2021

Commits on Dec 14, 2021

  1. Provide pdb file for cydlib/bin on Windows in a pdb_file output group 

    I've chose the `pdb_file` name for the output group since it matches
what `cc_binary` uses
(https://cs.opensource.google/bazel/bazel/+/master:src/main/java/com/google/devtools/build/lib/rules/cpp/CcBinary.java;l=707)

There is one edge case that is not covered here: if the user passes
`/DEBUG:NONE` in the `rustc_flags` no pdb will be generated and I
imagine the build will fail since it's now missing an output. I guess we
could check the `rustc_flags` for it but I don't know if it's the right
place to do so?
    @ddeville
    ddeville committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    0bc4fdf View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2021

  1. Merge branch 'main' into windows-pdb

    @ddeville
    ddeville committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    2c92366 View commit details
    Browse the repository at this point in the history