logically revert https://github.com/bazelbuild/rules_rust/pull/841 #1147
+27
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts rules_rust to use `-Lnative/-lstatic` instead of library paths per bazelbuild#840 (comment).
krasimirgg
added a commit
to krasimirgg/rules_rust
that referenced
this pull request
Feb 21, 2022
Depends on bazelbuild#1147. This addresses bazelbuild#840 by creating symlinks to ambiguous native dependencies of a rust_binary that would otherwise cause the link to fail, as in the examples added.
hlopko
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts rules_rust to use
-Lnative/-lstaticinstead of library paths per #840 (comment).Note for submission: I'd like we hold this off until the related #1148 is ready to be submitted so we can submit these closely together to ensure the examples added there do not regress over a large commit history window.