create symlinks to ambiguous native dependencies #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts rules_rust to use `-Lnative/-lstatic` instead of library paths per bazelbuild#840 (comment).
Add examples for bazelbuild#840.
Depends on bazelbuild#1147. This addresses bazelbuild#840 by creating symlinks to ambiguous native dependencies of a rust_binary that would otherwise cause the link to fail, as in the examples added.
krasimirgg
changed the title
krasimirgg
changed the title
hlopko
approved these changes
Feb 22, 2022
Co-authored-by: cfredric <cfredric@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1147.
This addresses #840 by creating symlinks to ambiguous native dependencies of a rust_binary that would otherwise cause the link to fail, as in the
example/s added.