Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for issue in linux Cargo binaries #1252

Merged
merged 7 commits into from
Apr 10, 2022
Merged

Workaround for issue in linux Cargo binaries #1252

merged 7 commits into from
Apr 10, 2022

Conversation

UebelAndre
Copy link
Collaborator

@UebelAndre UebelAndre commented Apr 8, 2022 •
edited
Loading

This allows crate_universe to handle rust-lang/cargo#10547.

Reviewers should only focus on 2e9facb

@UebelAndre UebelAndre mentioned this pull request Apr 8, 2022
Merged
@UebelAndre
Copy link
Collaborator Author

After re-pinning i ran into #1253. The solution for this is f19ea43.

@UebelAndre
Copy link
Collaborator Author

Also after re-pinning it seems //crate_universe:rustdoc_test started failing on MacOS. This PR would be a good candidate to investigate the root cause for #1233

@UebelAndre UebelAndre mentioned this pull request Apr 10, 2022
Closed
@UebelAndre UebelAndre merged commit b594f90 into bazelbuild:main Apr 10, 2022
@UebelAndre UebelAndre deleted the crate_universe branch April 10, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illicitonion illicitonion illicitonion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@UebelAndre @illicitonion