STATIC_RUST_URL sets the static.rust-lang.org URL #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change add the STATIC_RUST_URL environment variable to overwrite the URL to https://static.rust-lang.org when downloading the rust toolchain. This let the user specify using --action_env a mirror of static.rust-lang.org instead. This is particularly useful in China where https://static.rust-lang.org is really slow. For chinese user, the best way to proceed after this change is to add the following line in your ~/.bazelrc: ``` build --action_env STATIC_RUST_URL=http://mirrors.ustc.edu.cn/rust-static ```
acmcarther
approved these changes
Oct 23, 2018
|
@acmcarther: is there anything missing for this PR? |
|
Ah, sorry, no this looks good to me |
|
Thanks!
…On Wed, Nov 14, 2018 at 3:40 PM aiuto ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In rust/repositories.bzl
<#143 (comment)>:
> @@ -206,7 +206,8 @@ def load_arbitrary_tool(ctx, tool_name, param_prefix, tool_subdirectory, version
# N.B. See https://static.rust-lang.org/dist/index.html to find the tool_suburl for a given
# tool.
tool_suburl = produce_tool_suburl(tool_name, target_triple, version, iso_date)
- url = "https://static.rust-lang.org/dist/{}.tar.gz".format(tool_suburl)
+ static_rust = ctx.os.environ["STATIC_RUST_URL"] if "STATIC_RUST_URL" in ctx.os.environ else "https://static.rust-lang.org"
+ url = "{}/dist/{}.tar.gz".format(static_rust, tool_suburl)
Damien: you should be set now. dslomov@ changed the perms last night.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#143 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADjHf7CX5NVbde67WGBeFEZQVxzS66owks5uvCtLgaJpZM4X11Oe>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change add the STATIC_RUST_URL environment variable to overwrite
the URL to https://static.rust-lang.org when downloading the rust
toolchain. This let the user specify using --action_env a mirror of
static.rust-lang.org instead.
This is particularly useful in China where https://static.rust-lang.org
is really slow. For chinese user, the best way to proceed after this
change is to add the following line in your ~/.bazelrc: