Add android example #1545
Merged
Add android example #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith
force-pushed
the
ks/add-android-example
branch
2 times, most recently
from
8dd5a8f
to
6617732
Compare
This is mostly mirrored from https://github.com/keith/bazel-rust-mobile-demo but serves as a test / example to validate changes pushed to this repo. It requires you have an Android NDK / SDK setup to run.
keith
force-pushed
the
ks/add-android-example
branch
from
6617732
to
ba48442
Compare
UebelAndre
requested changes
Sep 8, 2022
| @@ -0,0 +1,50 @@ | |||
| workspace(name = "android_examples") | |||
There was a problem hiding this comment.
Does this need to be it's own workspace? I feel we'd get better coverage by having it be a part of rules_rust_examples
There was a problem hiding this comment.
the only annoyance is if you want to run those locally, you have to have the android SDK / NDK setup which I imagine most testers won't, I'm happy to merge them if you want though!
There was a problem hiding this comment.
I think it can be done at a later date but in general, fewer workspaces would be better
UebelAndre
approved these changes
Sep 8, 2022
|
@keith You wouldn't happen to have an iOS example project lying around would you 😄 (Thanks again!) |
|
Thanks! iOS example here #1546 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly mirrored from https://github.com/keith/bazel-rust-mobile-demo but serves as a test / example to validate changes pushed to this repo. It requires you have an Android NDK / SDK setup to run.