Remove -lgcc from Android builds #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer NDKs no longer have this library, if it's still needed for folks using older NDKs I think they'll have to manually link it.
UebelAndre
approved these changes
Sep 7, 2022
There was a problem hiding this comment.
Thanks! Do you think it'd be reasonable to add a small regression test that builds an apk or something to test targeting android? These flags are otherwise dead and I'm not sure any of the other maintainers would be be able to catch regressions for that platform without it :(
|
submitted here #1545 in this case this new test wouldn't have caught it without also bumping to the new NDK, but I agree it would be nice to have for other changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer NDKs no longer have this library, if it's still needed for folks
using older NDKs I think they'll have to manually link it.