Merge cc toolchain flags into build script env #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, setting build_script_env will _overwrite_ the values from the cc_toolchain, which is almost certainly ~always wrong. Instead, allow _appending_ values, which means that if overrides are necessary people can add them (e.g. disabling specific warnings). Note: This is technically a breaking change, but one which should improve faithfulness of the build.
UebelAndre
approved these changes
Nov 29, 2022
|
Unfortunately I don't think there's an easy way to - we'd need to have a cc_toolchain set up which provided non-empty flags here, which is complex to do. This example, which has one set up, seems like a very convenient place to avoid needing to set one up custom for test, but if anyone wants to / knows how, I'm happy to pick that up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, setting build_script_env will overwrite the values from the cc_toolchain, which is almost certainly ~always wrong.
Instead, allow appending values, which means that if overrides are necessary people can add them (e.g. disabling specific warnings).
Note: This is technically a breaking change, but one which should improve faithfulness of the build.