Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge cc toolchain flags into build script env #1675

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Merge cc toolchain flags into build script env #1675

merged 2 commits into from
Nov 29, 2022

Commits on Nov 29, 2022

  1. Merge cc toolchain flags into build script env 

    Right now, setting build_script_env will _overwrite_ the values from the
cc_toolchain, which is almost certainly ~always wrong.

Instead, allow _appending_ values, which means that if overrides are
necessary people can add them (e.g. disabling specific warnings).

Note: This is technically a breaking change, but one which should
improve faithfulness of the build.
    @illicitonion
    illicitonion committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    c66183c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into merge-flags

    @illicitonion
    illicitonion committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    d7137ec View commit details
    Browse the repository at this point in the history