Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix labels to work with canonical label literals. #1700

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

matts1
Copy link
Contributor

@matts1 matts1 commented Dec 15, 2022

For more details, see
https://docs.google.com/document/d/1N81qfCa8oskCk5LqTW-LNthy6EBrDot7bdUsjz6JFC4/edit#heading=h.5mcn15i0e1ch.

This allows us to use crate_universe on a repo with bzlmod enabled.

Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@illicitonion illicitonion merged commit 1469cd7 into bazelbuild:main Dec 15, 2022
matts1 added a commit to matts1/rules_rust that referenced this pull request Feb 16, 2023
@matts1 matts1 deleted the bzlmod_label branch November 10, 2023 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants