Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added CI for minimum supported Rust version #1720

Merged
merged 2 commits into from
Dec 22, 2022
Merged

Added CI for minimum supported Rust version #1720

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cea0eb
Added CI for minimum supported Rust version
UebelAndre Dec 21, 2022
c310ffe
Merge branch 'main' into minrust
UebelAndre Dec 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .bazelci/presubmit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@
aspects_flags: &aspects_flags
- "--config=rustfmt"
- "--config=clippy"
min_rust_version_shell_commands: &min_rust_version_shell_commands
- sed -i 's|^rust_register_toolchains(|rust_register_toolchains(versions = ["1.59.0"],\n|' WORKSPACE.bazel
single_rust_channel_targets: &single_rust_channel_targets
- "--"
- "//..."
# These tests are expected to fail as they require both a nightly and stable toolchain.
- "-//test/unit/channel_transitions/..."
default_linux_targets: &default_linux_targets
- "//..."
default_macos_targets: &default_macos_targets
Expand Down Expand Up @@ -202,6 +209,19 @@ tasks:
build_targets: *default_linux_targets
test_targets: *default_linux_targets
build_flags: *aspects_flags
ubuntu2004_min_rust_version:
name: "Min Rust Version"
platform: ubuntu2004
shell_commands: *min_rust_version_shell_commands
build_targets: *single_rust_channel_targets
test_targets: *single_rust_channel_targets
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I think we should be testing the rules all together, there might be value in having more granular testing for this since the current failure on 1.58.0 is a failure in a transitive crate_universe dependency. Open to suggestions on how this should be structured.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scentini @krasimirgg any thoughts here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna merge for now. The jobs can be updated in a separate change.

ubuntu2004_min_rust_version_with_aspects:
name: "Min Rust Version With Aspects"
platform: ubuntu2004
shell_commands: *min_rust_version_shell_commands
build_targets: *single_rust_channel_targets
test_targets: *single_rust_channel_targets
build_flags: *aspects_flags
ubuntu2004_rolling_with_aspects:
name: "Rolling Bazel Version With Aspects"
bazel: "rolling"
Expand Down