Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate BUILD files using serde_starlark renderer #1746

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

dtolnay
Copy link
Contributor

@dtolnay dtolnay commented Jan 3, 2023

This PR is the result of for target in $(bazel query 'kind(crates_vendor, //...)') ; do bazel run ${target}; done in each of ./ and ./examples/crate_universe.

I saw that this repo only uses squash merges and I was hoping not to get this large generated change squashed into #1743 so that the implementation commit in crate_universe remains understandable afterward. I can rebase the generated files here after #1743 gets merged.

@dtolnay dtolnay force-pushed the 3rdparty branch 2 times, most recently from 7c49b2c to 56ba295 Compare January 4, 2023 16:56
@dtolnay dtolnay changed the title Regenerate crates_universe/3rdparty/crates using serde_starlark renderer Regenerate BUILD files using serde_starlark renderer Jan 4, 2023
@dtolnay
Copy link
Contributor Author

dtolnay commented Jan 4, 2023

Note I did not update ./examples/crate_universe_unnamed because I think that was missed from #1735, so running crates_vendor in there involves a bunch of versions getting changed. I wanted this PR to be just regenerating existing BUILD files and not bundled together with version changes.

@dtolnay dtolnay marked this pull request as ready for review January 4, 2023 17:15
Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@UebelAndre UebelAndre merged commit d6e3003 into bazelbuild:main Jan 4, 2023
@dtolnay dtolnay deleted the 3rdparty branch January 4, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants