-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-pinned all dependencies managed by crate_universe #1735
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get a different result after running crates_vendor
for wasm_bindgen/3rdparty, on the same commit.
It seems two of the wait-timeout
crate's bins are getting rendered in a different order.
It's unexpected to me that the generated BUILD files would be nondeterministic like this.
diff --git a/wasm_bindgen/3rdparty/crates/BUILD.bazel b/wasm_bindgen/3rdparty/crates/BUILD.bazel
index 51206d6e..ed072257 100644
--- a/wasm_bindgen/3rdparty/crates/BUILD.bazel
+++ b/wasm_bindgen/3rdparty/crates/BUILD.bazel
@@ -207,8 +207,8 @@ alias(
)
alias(
- name = "wait-timeout__exit",
- actual = "@rules_rust_wasm_bindgen__wait-timeout-0.2.0//:exit__bin",
+ name = "wait-timeout__reader",
+ actual = "@rules_rust_wasm_bindgen__wait-timeout-0.2.0//:reader__bin",
tags = ["manual"],
)
@@ -219,8 +219,8 @@ alias(
)
alias(
- name = "wait-timeout__reader",
- actual = "@rules_rust_wasm_bindgen__wait-timeout-0.2.0//:reader__bin",
+ name = "wait-timeout__exit",
+ actual = "@rules_rust_wasm_bindgen__wait-timeout-0.2.0//:exit__bin",
tags = ["manual"],
)
diff --git a/wasm_bindgen/3rdparty/crates/BUILD.wait-timeout-0.2.0.bazel b/wasm_bindgen/3rdparty/crates/BUILD.wait-timeout-0.2.0.bazel
index 610cd069..f15ee858 100644
--- a/wasm_bindgen/3rdparty/crates/BUILD.wait-timeout-0.2.0.bazel
+++ b/wasm_bindgen/3rdparty/crates/BUILD.wait-timeout-0.2.0.bazel
@@ -144,7 +144,7 @@ rust_library(
)
rust_binary(
- name = "exit__bin",
+ name = "reader__bin",
srcs = glob(
include = [
"**/*.rs",
@@ -171,7 +171,7 @@ rust_binary(
}),
crate_features = [
],
- crate_root = "src/bin/exit.rs",
+ crate_root = "src/bin/reader.rs",
data = select_with_or({
"//conditions:default": [
],
@@ -392,7 +392,7 @@ rust_binary(
)
rust_binary(
- name = "reader__bin",
+ name = "exit__bin",
srcs = glob(
include = [
"**/*.rs",
@@ -419,7 +419,7 @@ rust_binary(
}),
crate_features = [
],
- crate_root = "src/bin/reader.rs",
+ crate_root = "src/bin/exit.rs",
data = select_with_or({
"//conditions:default": [
],
@illicitonion I think this is ready to merge now. |
This was generated by running the following bash command: