Add s390x arch support #2616
Add s390x arch support #2616
Conversation
|
@UebelAndre - now we have buildifier binaries available for s390x arch from buildtools 7.3.1 https://github.com/bazelbuild/buildtools/releases/download/v7.3.1/buildifier-linux-s390x . Can we please update the same on ? |
|
@UebelAndre - I don't have access to retry or rerun buildifier on CI, please provide me the access to the same. |
You would just run buildifier on whatever machine you can and push the results to your branch. |
|
@UebelAndre - Can we upgrade the buildifier to 7.3.1? where we have s390x binary is available. |
Yeah, go ahead and bump the version 😄 |
|
@UebelAndre - I have fixed the buildifier CI failures, Can you please merge this PR, we need this for a customer deployment. |
|
@UebelAndre - All CI checks passed. Can you please help us on merging this PR. |
| @@ -48,6 +48,9 @@ rust_library( | |||
| "@rules_rust//rust/platform:i686-unknown-linux-gnu": [ | |||
| "errno", # i686-unknown-linux-gnu | |||
| ], | |||
| "@rules_rust//rust/platform:s390x-unknown-linux-gnu": [ | |||
There was a problem hiding this comment.
@Repana-Chowdappa I noticed on #2841 that this change goes away when I regenerate dependencies. How was this produced?
There was a problem hiding this comment.
@UebelAndre - any specific reason to remove this?
There was a problem hiding this comment.
These files are generated and if there is a change made to them they should be made in a way that regenerates into the file. The removal feels more like a miss where something was not hooked up correctly and I was wondering how these came to be in the first place.
|
@UebelAndre - when will be the next release for rules_rust? so that we will have rust available for s390x platform. |
This is continuing of #2557 , added buildifier code changes for s390x arch also.