Remove transition from binary/test/bench rules, add to grpc/proto #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mostly reverts commit a1d8936, removing the proc_macro_host_transition from most rules. This fixes bazelbuild#305, by no longer having a transition on rust_binary. It still solves bazelbuild#300 by adding this transition to rust_proto_library and rust_grpc_library. Those rules are meant to mirror rust_library, so they should share the same cfg values. Sharing the same configuration means that rust_proto_library or rust_grpc_library can be dependencies to rust_library or rust_binary and not cause another configuration of the library to be generated. The example introduced by bazelbuild#301 is moved in this commit into a subfolder to provide a more clear directory structure.
damienmg
approved these changes
Apr 21, 2020
|
Thanks for fixing that, awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly reverts commit a1d8936, removing the
proc_macro_host_transition from most rules. This fixes #305, by no
longer having a transition on rust_binary. It still solves #300 by
adding this transition to rust_proto_library and rust_grpc_library.
Those rules are meant to mirror rust_library, so they should share the
same cfg values. Sharing the same configuration means that
rust_proto_library or rust_grpc_library can be dependencies to
rust_library or rust_binary and not cause another configuration of the
library to be generated.
The example introduced by #301 is moved in this commit into a subfolder
to provide a more clear directory structure.