Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove transition from binary/test/bench rules, add to grpc/proto #309

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Remove transition from binary/test/bench rules, add to grpc/proto #309

merged 1 commit into from
Apr 21, 2020

Commits on Apr 20, 2020

  1. Remove transition from binary/test/bench rules, add to grpc/proto 

    This mostly reverts commit a1d8936, removing the
proc_macro_host_transition from most rules.  This fixes bazelbuild#305, by no
longer having a transition on rust_binary.  It still solves bazelbuild#300 by
adding this transition to rust_proto_library and rust_grpc_library.
Those rules are meant to mirror rust_library, so they should share the
same cfg values.  Sharing the same configuration means that
rust_proto_library or rust_grpc_library can be dependencies to
rust_library or rust_binary and not cause another configuration of the
library to be generated.

The example introduced by bazelbuild#301 is moved in this commit into a subfolder
to provide a more clear directory structure.
    @dfreese
    dfreese committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    702a896 View commit details
    Browse the repository at this point in the history