Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix native_deps_test to not rely on number of actions #605

Merged
merged 1 commit into from
Feb 24, 2021
Merged

Fix native_deps_test to not rely on number of actions #605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions test/unit/native_deps/native_deps_test.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ def _lib_has_no_native_libs_test_impl(ctx):
env = analysistest.begin(ctx)
tut = analysistest.target_under_test(env)
actions = analysistest.target_actions(env)
asserts.equals(env, 1, len(actions))
action = actions[0]
_assert_argv_contains(env, action, "--crate-type=lib")
_assert_argv_contains_not(env, action, "-lstatic=native_dep")
_assert_argv_contains_not(env, action, "-ldylib=native_dep")
return analysistest.end(env)
Expand All @@ -32,8 +32,8 @@ def _rlib_has_no_native_libs_test_impl(ctx):
env = analysistest.begin(ctx)
tut = analysistest.target_under_test(env)
actions = analysistest.target_actions(env)
asserts.equals(env, 1, len(actions))
action = actions[0]
_assert_argv_contains(env, action, "--crate-type=rlib")
_assert_argv_contains_not(env, action, "-lstatic=native_dep")
_assert_argv_contains_not(env, action, "-ldylib=native_dep")
return analysistest.end(env)
Expand All @@ -43,6 +43,7 @@ def _dylib_has_native_libs_test_impl(ctx):
tut = analysistest.target_under_test(env)
actions = analysistest.target_actions(env)
action = actions[0]
_assert_argv_contains(env, action, "--crate-type=dylib")
_assert_argv_contains(env, action, "-lstatic=native_dep")
return analysistest.end(env)

Expand All @@ -51,6 +52,7 @@ def _cdylib_has_native_libs_test_impl(ctx):
tut = analysistest.target_under_test(env)
actions = analysistest.target_actions(env)
action = actions[0]
_assert_argv_contains(env, action, "--crate-type=cdylib")
_assert_argv_contains(env, action, "-lstatic=native_dep")
return analysistest.end(env)

Expand All @@ -59,6 +61,7 @@ def _staticlib_has_native_libs_test_impl(ctx):
tut = analysistest.target_under_test(env)
actions = analysistest.target_actions(env)
action = actions[0]
_assert_argv_contains(env, action, "--crate-type=staticlib")
_assert_argv_contains(env, action, "-lstatic=native_dep")
return analysistest.end(env)

Expand All @@ -68,6 +71,7 @@ def _proc_macro_has_native_libs_test_impl(ctx):
actions = analysistest.target_actions(env)
asserts.equals(env, 1, len(actions))
action = actions[0]
_assert_argv_contains(env, action, "--crate-type=proc-macro")
_assert_argv_contains(env, action, "-lstatic=native_dep")
return analysistest.end(env)

Expand Down