Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-gen cargo raze #642

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Re-gen cargo raze #642

merged 1 commit into from
Mar 22, 2021

Conversation

illicitonion
Copy link
Collaborator

These were generated with cargo-raze at
c748b0c4ed7ad6b516f7838a27fee27a9d9c8664.

This removes the need to manually edit
examples/complex_sys/raze/remote/BUILD.libssh2-sys-0.2.20.bazel as well
as adding the links attribute to crates which need it, allowing us to
remove cargo_build_script's crate_name attribute.

These were generated with cargo-raze at
c748b0c4ed7ad6b516f7838a27fee27a9d9c8664.

This removes the need to manually edit
examples/complex_sys/raze/remote/BUILD.libssh2-sys-0.2.20.bazel as well
as adding the `links` attribute to crates which need it, allowing us to
remove `cargo_build_script`'s `crate_name` attribute.
@UebelAndre
Copy link
Collaborator

link for easy reference: google/cargo-raze@c748b0c

Copy link
Member

@hlopko hlopko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is practically unreviewable :) I'd also say that raze should generate minimal and buildifier compliant BUILD files, generating these loads and not using them is not great.

@illicitonion illicitonion merged commit a3d4b12 into bazelbuild:main Mar 22, 2021
@illicitonion illicitonion deleted the update-raze branch March 22, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants