Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't apply name_to_crate_name to test binary names. #670

Merged
merged 3 commits into from
Mar 31, 2021
Merged

Don't apply name_to_crate_name to test binary names. #670

merged 3 commits into from
Mar 31, 2021

Commits on Mar 31, 2021

  1. Don't apply name_to_crate_name to test binary names. 

    Normal `rust_binary` targets don't do this, so for consistency, don't do
it in tests either.

An additional motivation for this change is that I'm trying to whittle down
the number of uses of the `name_to_crate_name` function, as it doesn't
take a possible `crate_name` attribute into account. For context, see
also the changes and discussion in

bazelbuild#645
    @martinboehme
    martinboehme committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    010379b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into test-binary-names

    @hlopko
    hlopko authored Mar 31, 2021
    Configuration menu
    Copy the full SHA
    7364a50 View commit details
    Browse the repository at this point in the history

  3. Remove load of unused symbol.

    @martinboehme
    martinboehme committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    ef9175f View commit details
    Browse the repository at this point in the history