Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use un-released fix to semver-parser #731

Merged
merged 2 commits into from
May 10, 2021
Merged

Conversation

illicitonion
Copy link
Collaborator

semver 0.11.0 changed the behaviour of parsing x.y requirements - in
semver 0.10 it treated them as >=x.y.0, <(x+1).0.0 and in semver 0.11
it treated them as >=x.y.0, <x.(y+1).0.

cargo itself is still using semver 0.10.0, but cargo_metadata and
cargo-lock have updated to semver 0.11.0, which means that cargo and
crate_universe currently treat these version ranges differently.

This patch restores the semver 0.10.0 behaviour, which means that
cargo and crate_universe will resolve things the same.

semver 0.11.0 changed the behaviour of parsing `x.y` requirements - in
semver 0.10 it treated them as `>=x.y.0, <(x+1).0.0` and in semver 0.11
it treated them as `>=x.y.0, <x.(y+1).0`.

`cargo` itself is still using semver 0.10.0, but `cargo_metadata` and
`cargo-lock` have updated to semver 0.11.0, which means that `cargo` and
`crate_universe` currently treat these version ranges differently.

This patch restores the `semver 0.10.0` behaviour, which means that
`cargo` and `crate_universe` will resolve things the same.
Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch and thanks for the link!

@UebelAndre UebelAndre merged commit 8a35f35 into bazelbuild:main May 10, 2021
@illicitonion illicitonion deleted the semver branch May 10, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants