rustfmt_aspect now appropriately uses a config
#748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -108,6 +110,11 @@ users may tag a target with `norustfmt` to have it skipped. Additionally, genera | |||
| source files are also ignored by this aspect. | |||
| """, | |||
| attrs = { | |||
| "_config": attr.label( | |||
There was a problem hiding this comment.
I'd be inclined to make this configurable (i.e. remove the leading _) so that people can override it if they really want - WDYT?
There was a problem hiding this comment.
Is that possible in an aspect?
There was a problem hiding this comment.
Oh, yeah, right! Indeed!
illicitonion
approved these changes
May 19, 2021
| @@ -108,6 +110,11 @@ users may tag a target with `norustfmt` to have it skipped. Additionally, genera | |||
| source files are also ignored by this aspect. | |||
| """, | |||
| attrs = { | |||
| "_config": attr.label( | |||
There was a problem hiding this comment.
Oh, yeah, right! Indeed!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to add this attribute in the initial PR. Now the check should appropriately use the configured
rustfmt.tomlfile.