-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make rust analyzer aspect follow rust_test.crate attribute #751
Conversation
2515d40
to
a82d193
Compare
CC @djmarcin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorta feels like there's two changes here? They seem good but curious as to what brought on the harness
attribute.
Oops, there's another PR 😅
But yeah, was it necessary for this or just a nicety?
I pass a path to rust-project.json as a command line arg to the test.
Now that I'm forced to think about this more, I found alternatives:
I'm inclined to pursue the runfiles alternative (but I think the harness PR still makes sense and can go in). |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@googlebot I fixed it. |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
1 similar comment
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
7127fe1
to
da8b3ab
Compare
And finally we have a green CI. PTAL :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! a small nit and one question that's more of an aside 😅
This looks good to me! Feel free to merge whenever you'd like 😄 and thanks! |
Before, generated rust-project.json did not contain dependencies from the
rust_library
whenrust_test
used.crate
attribute and the test was the only root in thetargets
attribute ofrust_analyzer
rule.This PR depends on #754 and #760.