Use the rust-src tool for fetching rust source #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlopko
reviewed
Jul 20, 2021
rust/private/repository_utils.bzl
Outdated
| Returns: | ||
| str: The fully qualified url path for the specified tool. | ||
| """ | ||
| url = "" | ||
| if iso_date: |
There was a problem hiding this comment.
There is no excuse for not having a unit test for this function :) I just uploaded #846.
There was a problem hiding this comment.
(feel free to merge it and add a test for none in target_triple)
rust/private/repository_utils.bzl
Outdated
| return "{}-{}-{}".format(tool_name, version, target_triple) | ||
| url += "{}/".format(iso_date) | ||
| if tool_name: | ||
| url += tool_name |
There was a problem hiding this comment.
Tool is not an optional argument, let'sfail() with an error message when None is passed. Same for version.
rust/private/repository_utils.bzl
Outdated
| if tool_name: | ||
| url += tool_name | ||
| if version: | ||
| url += "-{}".format(version) |
There was a problem hiding this comment.
What do you think about alternative code (not tested):
result = "-".join([e for e in [tool_name, target_triple,version] if e])
if iso_date:
return iso_date + "/" + result
else:
return resultCombining += and format is imho confusing and cumbersome.
This tool only includes the relevant rust source files, significantly slimming the size of the download, and significantly decreasing the number of bazel targets generated. The concept of a "host tool" is introduced, which is targetless, to accommodate this change.
|
CC @UebelAndre FYI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tool only includes the relevant rust source files, significantly slimming the size of the download, and significantly decreasing the number of bazel targets generated. The concept of a "host tool" is introduced, which is targetless, to accommodate this change.
This partially fixes #833.