Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add repository_utils_test.bzl #846

Merged
merged 5 commits into from
Jul 20, 2021
Merged

Add repository_utils_test.bzl #846

merged 5 commits into from
Jul 20, 2021

Conversation

hlopko
Copy link
Member

@hlopko hlopko commented Jul 20, 2021

No description provided.

@google-cla google-cla bot added the cla: yes label Jul 20, 2021
@hlopko hlopko requested a review from UebelAndre July 20, 2021 20:01
@hlopko hlopko mentioned this pull request Jul 20, 2021
Merged
UebelAndre
UebelAndre approved these changes Jul 20, 2021
View reviewed changes
Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I super appreciate a test-only PR I hope to see more and am inspired to try and make some myself!

This seems fine to me assuming buildifier is made to agree 😄

@hlopko hlopko merged commit 19acfd8 into bazelbuild:main Jul 20, 2021
@hlopko hlopko deleted the add_repository_utils_test branch July 20, 2021 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UebelAndre UebelAndre UebelAndre approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hlopko @UebelAndre