Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose documentation for rust_test_binary #876

Closed
wants to merge 2 commits into from

Conversation

UebelAndre
Copy link
Collaborator

I didn't know this rule existed. Since it's exposed in //rust:defs.bzl, I think it should be included in documentation.

@google-cla google-cla bot added the cla: yes label Aug 4, 2021
@UebelAndre
Copy link
Collaborator Author

UebelAndre commented Aug 4, 2021

Though, I'm wondering if this is something that should just be deprecated. How experimental is this? How widely is it used?

@UebelAndre
Copy link
Collaborator Author

#316 appears to be the origins of this rule.

@hlopko
Copy link
Member

hlopko commented Aug 5, 2021

Oh wow I also didn't know it exists. I wonder if it's actually needed even for the person who contributed it now since rust_test can setup environment variables directly.

@tommilligan do you still use rust_test_binary? Could you instead use rust_test with declaring env variables?

@tommilligan
Copy link
Contributor

I don't have anything active in flight with Bazel currently, so happy for you to remove if you want to.

@UebelAndre UebelAndre closed this Aug 9, 2021
@UebelAndre
Copy link
Collaborator Author

Created #880

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants