Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete rust_test_binary #880

Merged
merged 3 commits into from
Aug 12, 2021
Merged

Delete rust_test_binary #880

merged 3 commits into from
Aug 12, 2021

Conversation

UebelAndre
Copy link
Collaborator

Now that rust_test supports an env attribute for setting environment variables for test targets, the rust_test_binary rule should no longer be necessary. This PR removes it.

@google-cla google-cla bot added the cla: yes label Aug 9, 2021
@UebelAndre UebelAndre mentioned this pull request Aug 9, 2021
Closed
@UebelAndre UebelAndre requested a review from hlopko August 9, 2021 22:05
hlopko
hlopko approved these changes Aug 10, 2021
View reviewed changes
Copy link
Member

@hlopko hlopko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for cleaning it up!

@UebelAndre UebelAndre merged commit 1e4fbe3 into bazelbuild:main Aug 12, 2021
@UebelAndre UebelAndre deleted the test-binary branch August 12, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlopko hlopko hlopko approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@UebelAndre @hlopko