Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete rust_test_binary #880

Merged
merged 3 commits into from
Aug 12, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions rust/defs.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ load(
_rust_shared_library = "rust_shared_library",
_rust_static_library = "rust_static_library",
_rust_test = "rust_test",
_rust_test_binary = "rust_test_binary",
_rust_test_suite = "rust_test_suite",
)
load(
Expand Down Expand Up @@ -77,9 +76,6 @@ rust_binary = _rust_binary
rust_test = _rust_test
# See @rules_rust//rust/private:rust.bzl for a complete description.

rust_test_binary = _rust_test_binary
# See @rules_rust//rust/private:rust.bzl for a complete description.

rust_test_suite = _rust_test_suite
# See @rules_rust//rust/private:rust.bzl for a complete description.

Expand Down
26 changes: 0 additions & 26 deletions rust/private/rust.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -1127,32 +1127,6 @@ rust_test = rule(
"""),
)

rust_test_binary = rule(
implementation = _rust_test_impl,
provides = _common_providers,
attrs = dict(_common_attrs.items() +
_rust_test_attrs.items()),
executable = True,
fragments = ["cpp"],
host_fragments = ["cpp"],
toolchains = [
str(Label("//rust:toolchain")),
"@bazel_tools//tools/cpp:toolchain_type",
],
incompatible_use_toolchain_transition = True,
doc = dedent("""\
Builds a Rust test binary, without marking this rule as a Bazel test.

**Warning**: This rule is currently experimental.

This should be used when you want to run the test binary from a different test
rule (such as [`sh_test`](https://docs.bazel.build/versions/master/be/shell.html#sh_test)),
and know that running the test binary directly will fail.

See `rust_test` for example usage.
"""),
)

def rust_test_suite(name, srcs, **kwargs):
"""A rule for creating a test suite for a set of `rust_test` targets.

Expand Down
4 changes: 0 additions & 4 deletions rust/rust.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ load(
_rust_shared_library = "rust_shared_library",
_rust_static_library = "rust_static_library",
_rust_test = "rust_test",
_rust_test_binary = "rust_test_binary",
)
load("//rust/settings:incompatible.bzl", "fail_when_enabled")

Expand Down Expand Up @@ -70,9 +69,6 @@ rust_binary = _rust_binary
rust_test = _rust_test
# See @rules_rust//rust/private:rust.bzl for a complete description.

rust_test_binary = _rust_test_binary
# See @rules_rust//rust/private:rust.bzl for a complete description.

rust_benchmark = _rust_benchmark
# See @rules_rust//rust/private:rust.bzl for a complete description.

Expand Down
27 changes: 0 additions & 27 deletions test/rust_test_binary/BUILD.bazel

This file was deleted.

9 changes: 0 additions & 9 deletions test/rust_test_binary/scripts/exec_with_test_env.sh

This file was deleted.

11 changes: 0 additions & 11 deletions test/rust_test_binary/tests/rust_test_that_requires_wrapping.rs

This file was deleted.