Support additional registries #942
Conversation
|
/cc @wt - sorry this took longer to get out than I expected, there was a lot of rebasing to do! |
|
Don't be sorry. And keep being awesome. |
illicitonion
force-pushed
the
additional-registries2
branch
2 times, most recently
from
86b3d19
to
13ee51e
Compare
illicitonion
force-pushed
the
additional-registries2
branch
from
13ee51e
to
8108cf8
Compare
There was a problem hiding this comment.
Can you explain what this change is doing? I think I misunderstood it initially. Is this adding plumbing to add a Cargo config to the cargo metadata call?
Also one nit 😄
| @@ -6,9 +6,9 @@ load("//rust:defs.bzl", "rust_common") | |||
| load("//rust:repositories.bzl", "DEFAULT_TOOLCHAIN_TRIPLES") | |||
| load("//rust/platform:triple_mappings.bzl", "system_to_binary_ext", "triple_to_system") | |||
|
|
|||
| DEFAULT_CRATE_REGISTRY_TEMPLATE = "https://crates.io/api/v1/crates/{crate}/{version}/download" | |||
| DEFAULT_DEFAULT_CRATE_DOWNLOAD_URL_TEMPLATE = "https://crates.io/api/v1/crates/{crate}/{version}/download" | |||
There was a problem hiding this comment.
Intentional (but definitely looks weird!)
DEFAULT_CRATE_DOWNLOAD_URL_TEMPLATE is the crate download URL template for crates from the default registry (i.e. crates.io)
This is the default value for that
There was a problem hiding this comment.
Maybe add a comment above this then?
There was a problem hiding this comment.
Fair - added comment :)
Yes - this is the interface |
I see, I think this looks fine then, pending my other request. Nice job with the paired change! |
No description provided.