Support additional registries #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
force-pushed
the
additional_registries
branch
2 times, most recently
from
856540a
to
3264a46
Compare
acmcarther
requested changes
Apr 13, 2021
illicitonion
force-pushed
the
additional_registries
branch
from
3264a46
to
c3655e2
Compare
|
@acmcarther I addressed the comments - could I nudge you towards a merge? :) Thanks! |
|
@acmcarther Friendly ping? :) |
illicitonion
force-pushed
the
additional_registries
branch
2 times, most recently
from
9d036eb
to
1515b3f
Compare
UebelAndre
approved these changes
Aug 25, 2021
This relies on the registry information being in .cargo/config.toml (and will proactively error if other keys are found in there). The reason for this is that we need to run `cargo metadata` before we even parse out config, and we can't run `cargo metadata` without having this data active for that `cargo` invocation. It also simplifies implementation a lot, by just copying around one file rather than needing to generate config for `cargo` to use. Raze will hard-error if a `.cargo/config.toml` is present containing keys it doesn't understand.
illicitonion
force-pushed
the
additional_registries
branch
from
1515b3f
to
8bedf23
Compare
I have done - the changes are included in this PR :) (Specifically adding the |
UebelAndre
approved these changes
Aug 25, 2021
|
@illicitonion Hey, I think this introduced a regression bazel run //tools:examples_razediff --git a/examples/remote/binary_dependencies/cargo/crates.bzl b/examples/remote/binary_dependencies/cargo/crates.bzl
index b4142103..f3f2ba9e 100644
--- a/examples/remote/binary_dependencies/cargo/crates.bzl
+++ b/examples/remote/binary_dependencies/cargo/crates.bzl
@@ -772,7 +772,7 @@ def remote_binary_dependencies_fetch_remote_crates():
maybe(
http_archive,
name = "remote_binary_dependencies__texture_synthesis_cli__0_8_0",
- url = "https://crates.io/api/v1/crates/texture-synthesis-cli/0.8.0/download",
+ url = "",
type = "tar.gz",
sha256 = "4d0a65298b735ba486081633e90469182d7c0ca59018fec1e81383bde852be2e",
strip_prefix = "texture-synthesis-cli-0.8.0",The |
|
Oh no! Fix here: #442 (with a test!) - thanks for the heads up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relies on the registry information being in .cargo/config.toml (and
will proactively error if other keys are found in there).
The reason for this is that we need to run
cargo metadatabefore weeven parse out config, and we can't run
cargo metadatawithout havingthis data active for that
cargoinvocation. It also simplifiesimplementation a lot, by just copying around one file rather than
needing to generate config for
cargoto use.Fixes #24.