-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support additional registries #412
Conversation
856540a
to
3264a46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally lg, but i feel somewhat strongly that this should not fail on unknown fields.
3264a46
to
c3655e2
Compare
@acmcarther I addressed the comments - could I nudge you towards a merge? :) Thanks! |
@acmcarther Friendly ping? :) |
9d036eb
to
1515b3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me 😄. A couple of small comments and can you run bazel run //tools:bootstrap && bazel run //tools:examples_raze && bazel test //...
locally just to make sure nothing changed about the generated files?
This relies on the registry information being in .cargo/config.toml (and will proactively error if other keys are found in there). The reason for this is that we need to run `cargo metadata` before we even parse out config, and we can't run `cargo metadata` without having this data active for that `cargo` invocation. It also simplifies implementation a lot, by just copying around one file rather than needing to generate config for `cargo` to use. Raze will hard-error if a `.cargo/config.toml` is present containing keys it doesn't understand.
1515b3f
to
8bedf23
Compare
I have done - the changes are included in this PR :) (Specifically adding the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing the cleanup! Looks good to me 😄
@illicitonion Hey, I think this introduced a regression bazel run //tools:examples_raze diff --git a/examples/remote/binary_dependencies/cargo/crates.bzl b/examples/remote/binary_dependencies/cargo/crates.bzl
index b4142103..f3f2ba9e 100644
--- a/examples/remote/binary_dependencies/cargo/crates.bzl
+++ b/examples/remote/binary_dependencies/cargo/crates.bzl
@@ -772,7 +772,7 @@ def remote_binary_dependencies_fetch_remote_crates():
maybe(
http_archive,
name = "remote_binary_dependencies__texture_synthesis_cli__0_8_0",
- url = "https://crates.io/api/v1/crates/texture-synthesis-cli/0.8.0/download",
+ url = "",
type = "tar.gz",
sha256 = "4d0a65298b735ba486081633e90469182d7c0ca59018fec1e81383bde852be2e",
strip_prefix = "texture-synthesis-cli-0.8.0", The |
Oh no! Fix here: #442 (with a test!) - thanks for the heads up! |
This relies on the registry information being in .cargo/config.toml (and
will proactively error if other keys are found in there).
The reason for this is that we need to run
cargo metadata
before weeven parse out config, and we can't run
cargo metadata
without havingthis data active for that
cargo
invocation. It also simplifiesimplementation a lot, by just copying around one file rather than
needing to generate config for
cargo
to use.Fixes #24.