Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build is not identical when scala rules compile java sources #108

Closed
johnynek opened this issue Nov 5, 2016 · 3 comments
Closed

Build is not identical when scala rules compile java sources #108

johnynek opened this issue Nov 5, 2016 · 3 comments

Comments

@johnynek
Copy link
Member

johnynek commented Nov 5, 2016

See example failures in #101 #106

This seems to only happen on linux. The most common reason is that somehow a timestamp is making it into an output file. We should be able to check by looking at the binary diff to find the actual difference.

We need to fix this because we can't merge a test that makes the build go red, but at the same time, this means currently when using mixed scala/java targets on linux, you will not have optimal caching (each upstream rebuild will invalidate everything downstream).

@ittaiz
Copy link
Member

ittaiz commented Nov 6, 2016

my 2c- I thought it doesn't break on OSX just because of #74 but when I changed test_run.sh locally to use md5 (and not md5sum) it didn't break on the only_java_sources branch. I wonder what's going on there...

@ittaiz
Copy link
Member

ittaiz commented Nov 6, 2016

also how do you explain #104 not showing the same symptoms? do you think it's somehow order related?

@ittaiz
Copy link
Member

ittaiz commented Sep 2, 2017

I'm closing this since we've done a lot of work on this area and I haven't seen any failures or flakiness in this area for a long while.

@ittaiz ittaiz closed this as completed Sep 2, 2017
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants