Java only sources #106
Merged
Java only sources #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
I actually added the test since I thought about it and saw that I did it manually (added a compilation error in the class) and saw the build break so I decided to automate it. |
|
For some reason, this test fails the identical output test. We need to figure out why. Somehow, building the second time is not producing exactly the same output on linux. |
|
This looks good against the rebased master. Tests are passing on my local mac and on TravisCI too https://travis-ci.org/sentinelleader/rules_scala/builds/178413682, 😲 |
|
nice @ittaiz want to rebase and see if we can merge? |
ittaiz
force-pushed
the
only_java_sources
branch
from
2d80565
to
c275ade
Compare
|
@johnynek done. Let me know if anything else is needed. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an already passing test-target which shows support of targets with java only sources.
I think it has value even if it's already passing since at least currently this is a feature we want to support (until #970 in bazel itself is resolved) and I'd be calmer if there was any regression check for it.
Do you think an actual test is needed?