Scrooge --finagle

[arjantop]

Is it possible to generate finagle services with current scrooge support? (like passing --finagle in sbt plugin)

[johnynek]

I don't think so, but it probably wouldn't be too hard to add. Happy to help suggest how to make a change in a PR if you have time to submit one.

…

On Sat, Dec 17, 2016 at 01:01 Arjan Topolovec ***@***.***> wrote: Is it possible to generate finagle services with current scrooge support? (like passing --finagle in sbt plugin) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#117>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEJdpRA2M4SGJhbHWmYW6oSBKSVDF4rks5rI8EOgaJpZM4LP3DZ> .

[arjantop]

Just hacked together a "fix": https://github.com/arjantop/rules_scala

Only experimenting now, will probably try to add this once I get the feel how things work/fit together.

[johnynek]

great. Would love a PR when it is working well for you.

[kevingessner]

@arjantop Did you submit a PR for this? I'm in search of same finagle support.

[arjantop]

@kevingessner sorry, no, did not really have time to do this (experimenting with bazel was just my hobby project)

[johnynek]

@kevingessner any interest in a PR that adds that as an option to scooge targets and correctly sets up the finagle dependency when it exists?

[kevingessner]

That would be great. I have a branch that enables the finagle flag, but it's not on top of rules_scala master (because of the new bazel 0.5.3 requirement). I'll try to get it in shape next week and submit it.